Confirmation by pressing Space on confirm screens#784
Conversation
|
@blueorangutan package |
|
@utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️centos ✔️debian ✔️archive. |
|
Good to have, could this cause any regressions? |
|
@rhtyd I think it won't cause a regression. Thanks. |
|
@utchoang I think what @borisstoyanov meant was that hitting space toggles the value of the first button / checkbox / switch. An autofocus on the first form item would be an appropriate fix |
|
@blueorangutan package |
|
@utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️centos ✔️debian ✔️archive. |
davidjumani
left a comment
davidjumani
left a comment
There was a problem hiding this comment.
LGTM. Need to check whether changes might be needed in other custom forms
Thanks @utchoang
* submit button when pressing Space on confirm modal * removed console * add auto-focus into switch & remove keyup function * revert message on storagejs
4 participants
Fixes #781
@rhtyd cc @svenvogel